-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always set alg and kid on expansion #518
Conversation
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-13T22:30:53Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 91.03% 91.11% +0.07%
==========================================
Files 116 116
Lines 29562 29664 +102
Branches 2177 2199 +22
==========================================
+ Hits 26912 27027 +115
+ Misses 2615 2602 -13
Partials 35 35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
This pr resolves #3 from this issue:
#497
Always set alg and kid on expansion (to the values in the registry), support overriding of alg values
toDnsPacket:
a
fromDnsPacket: