Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set alg and kid on expansion #518

Merged
merged 2 commits into from
May 13, 2024
Merged

Always set alg and kid on expansion #518

merged 2 commits into from
May 13, 2024

Conversation

nitro-neal
Copy link
Contributor

This pr resolves #3 from this issue:
#497

Always set alg and kid on expansion (to the values in the registry), support overriding of alg values

toDnsPacket:

  • check if the alg on the JWK == the alg in the default registry for the given key type. Otherwise add it to the txt document as a

fromDnsPacket:

  • KID is always either 0 for the identity key or the JWK thumbprint for all other keys (no overriding it)
  • the alg is always set to the default from the registry (https://did-dht.com/registry/#key-type-index) but can be overriden if you specify the alg property

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: ad515b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nitro-neal nitro-neal requested a review from decentralgabe May 7, 2024 21:32
Copy link
Contributor

github-actions bot commented May 7, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-05-13T22:30:53Z ad515b8

decentralgabe
decentralgabe previously approved these changes May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (eabe5ca) to head (ad515b8).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   91.03%   91.11%   +0.07%     
==========================================
  Files         116      116              
  Lines       29562    29664     +102     
  Branches     2177     2199      +22     
==========================================
+ Hits        26912    27027     +115     
+ Misses       2615     2602      -13     
  Partials       35       35              
Components Coverage Δ
agent 80.86% <ø> (+0.23%) ⬆️
api 97.93% <ø> (+0.16%) ⬆️
common 98.68% <ø> (ø)
credentials 95.26% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.70% <100.00%> (+<0.01%) ⬆️
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@nitro-neal nitro-neal merged commit eef9396 into main May 13, 2024
11 checks passed
@nitro-neal nitro-neal deleted the alg-kid-expansion branch May 13, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe api
4 participants