-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QoL] Fixed annoying TypeDoc errors that have been a distraction to PRs #506
Conversation
thehenrytsai
commented
May 1, 2024
•
edited
Loading
edited
- Fixed annoying TypeDoc errors that have been a distraction to PRs
- Also turned on fail-on-error for TypeDoc generation during CI so TypeDoc warnings only annoys the person who introduces it.
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-01T18:44:56Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 90.80% 90.81%
=======================================
Files 116 116
Lines 29409 29425 +16
Branches 2156 2156
=======================================
+ Hits 26706 26722 +16
Misses 2668 2668
Partials 35 35
|
The typedocs message is still gigantic. Any reason it's doing this, can we fix?
|
@shamilovtim probably there is a way, but I have no desire to go beyond this right now, but feel free to take a stab at this, just consider RoI if you are at it. I think this baby step is a good win already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions around how thorough we want the docs to be in the future and whether return types and param types are auto generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Maybe we can include this also with the PR since we've been having issues with pnpm
builds due to type inference.
@thehenrytsai don't forget to add a |