Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract parentContextId from record when updating #494

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

LiranCohen
Copy link
Member

When updating a record, we currently pass in the record descriptor int the create options, however if the record has a parent we must set the parentContextId.

In order to do this we extract the parentId from the descriptor, and if it exists we set a parentContextId.

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 35bb8b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 16, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 4

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts
📄 File: ./packages/crypto-aws-kms/src/ecdsa.ts
⚠️ extractor:typedoc:missing-docs: EcdsaAlgorithm (Class) does not have any documentation.
📄 File: ./packages/crypto-aws-kms/src/key-manager.ts
⚠️ extractor:typedoc:missing-docs: AwsKeyManager (Class) does not have any documentation.
📄 File: ./packages/crypto-aws-kms/src/utils.ts
⚠️ extractor:typedoc:missing-docs: getKeySpec (CallSignature) does not have any documentation.
🔀 Misc.
⚠️ extractor:typedoc:invalid-link: Failed to resolve link to "@web5/crypto#Secp256k1.adjustSignatureToLowS | here" in comment for EcdsaAlgorithm.sign. You may have wanted "@web5/crypto!Secp256k1.adjustSignatureToLowS | here"

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-04-16T01:44:08Z 35bb8b0

@codecov-commenter
Copy link

Codecov Report

Merging #494 (35bb8b0) into main (c8e6fa8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files         112      112           
  Lines       29085    29091    +6     
  Branches     2078     2079    +1     
=======================================
+ Hits        26338    26344    +6     
  Misses       2712     2712           
  Partials       35       35           
Components Coverage Δ
agent 78.83% <ø> (ø)
api 97.89% <100.00%> (+<0.01%) ⬆️
common 98.68% <ø> (ø)
credentials 95.21% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.65% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

@LiranCohen LiranCohen merged commit d12eff8 into main Apr 16, 2024
9 of 10 checks passed
@LiranCohen LiranCohen deleted the lirancohen/update-record-parent-context branch April 16, 2024 16:33
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants