Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSP Reusable Workflow for Scans #467

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

leordev
Copy link
Contributor

@leordev leordev commented Mar 27, 2024

Similar to TBD54566975/developer.tbd.website#1348

It also include the OSSF Scan checks.

PS: Note that it's fine to reuse a workflow without pinning the dependency because OSSF checks for the nested workflow. (In this case we are setting to main branch TBD54566975/open-source-programs/.github/workflows/security.yml@main ).

Copy link
Contributor

github-actions bot commented Mar 27, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 4

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts
📄 File: ./packages/crypto-aws-kms/src/ecdsa.ts
⚠️ extractor:typedoc:missing-docs: EcdsaAlgorithm (Class) does not have any documentation.
📄 File: ./packages/crypto-aws-kms/src/key-manager.ts
⚠️ extractor:typedoc:missing-docs: AwsKeyManager (Class) does not have any documentation.
📄 File: ./packages/crypto-aws-kms/src/utils.ts
⚠️ extractor:typedoc:missing-docs: getKeySpec (CallSignature) does not have any documentation.
🔀 Misc.
⚠️ extractor:typedoc:invalid-link: Failed to resolve link to "@web5/crypto#Secp256k1.adjustSignatureToLowS | here" in comment for EcdsaAlgorithm.sign. You may have wanted "@web5/crypto!Secp256k1.adjustSignatureToLowS | here"

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-04-03T15:47:30Z 810ed68

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

Merging #467 (1728401) into main (070d892) will increase coverage by 2.86%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 1728401 differs from pull request most recent head 810ed68. Consider uploading reports for the commit 810ed68 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   90.54%   93.40%   +2.86%     
==========================================
  Files         112       80      -32     
  Lines       29085    24014    -5071     
  Branches     2078     1925     -153     
==========================================
- Hits        26335    22431    -3904     
+ Misses       2715     1538    -1177     
- Partials       35       45      +10     
Components Coverage Δ
agent 88.72% <ø> (+9.89%) ⬆️
api 97.30% <ø> (-0.44%) ⬇️
common 98.68% <ø> (ø)
credentials 94.95% <ø> (-0.26%) ⬇️
crypto 93.81% <ø> (ø)
dids 97.65% <ø> (ø)
identity-agent 56.81% <ø> (-39.89%) ⬇️
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 58.43% <ø> (-38.28%) ⬇️
user-agent 55.22% <ø> (-41.49%) ⬇️

@leordev leordev force-pushed the leordev/osp-workflow-scan branch from 1728401 to ac76971 Compare April 3, 2024 15:43
Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leordev Nice work for abstracting these workflows away from the dependent repos!

@leordev leordev merged commit 69c2b52 into main May 18, 2024
10 checks passed
@leordev leordev deleted the leordev/osp-workflow-scan branch May 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants