Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DidUri to Did #400

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Rename DidUri to Did #400

merged 2 commits into from
Feb 5, 2024

Conversation

frankhinek
Copy link
Contributor

Rename the DidUri to Did per decentralized-identity/web5-spec#112 (comment)

closes #399

@frankhinek
Rename DidUri to Did
c469775 
Signed-off-by: Frank Hinek <[email protected]>
@frankhinek frankhinek self-assigned this Feb 3, 2024
@codesandbox CodeSandbox
Copy link

codesandbox bot commented Feb 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2024 •
edited
Loading

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

TBDocs Report Updated at 2024-02-03T15:46:26Z 85ec434

@codecov Codecov
Copy link

codecov bot commented Feb 3, 2024 •
edited
Loading

Codecov Report

Merging #400 (85ec434) into main (ab117f1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   93.25%   93.24%   -0.02%     
==========================================
  Files          77       77              
  Lines       23454    23454              
  Branches     1869     1869              
==========================================
- Hits        21873    21870       -3     
- Misses       1542     1545       +3     
  Partials       39       39
Components Coverage Δ
agent 88.72% <ø> (ø)
api 97.11% <ø> (-0.19%) ⬇️
common 98.67% <ø> (ø)
credentials 94.60% <ø> (ø)
crypto 93.76% <ø> (ø)
dids 97.35% <100.00%> (ø)
identity-agent 56.81% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 58.43% <ø> (ø)
user-agent 55.22% <ø> (ø)

LiranCohen
LiranCohen reviewed Feb 3, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one missed comment.

packages/dids/src/did.ts Outdated Show resolved Hide resolved
@frankhinek frankhinek requested a review from LiranCohen February 3, 2024 15:44
LiranCohen
LiranCohen approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

mistermoe
mistermoe approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankhinek frankhinek merged commit 3f437dd into main Feb 5, 2024
34 checks passed
@frankhinek frankhinek deleted the diduri-to-did branch February 5, 2024 09:06
finn-block pushed a commit that referenced this pull request Mar 19, 2024
@frankhinek @finn-block
Rename DidUri to Did (#400)
809957c 
* Rename DidUri to Did

---------

Signed-off-by: Frank Hinek <[email protected]>
finn-block pushed a commit that referenced this pull request Mar 19, 2024
@frankhinek @finn-block
Rename DidUri to Did (#400)
d76be9f 
* Rename DidUri to Did

---------

Signed-off-by: Frank Hinek <[email protected]>
finn-block pushed a commit that referenced this pull request Mar 19, 2024
@frankhinek @finn-block
Rename DidUri to Did (#400)
95dd9df 
* Rename DidUri to Did

---------

Signed-off-by: Frank Hinek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistermoe mistermoe mistermoe approved these changes

@LiranCohen LiranCohen LiranCohen approved these changes

@nitro-neal nitro-neal Awaiting requested review from nitro-neal

@amika-sq amika-sq Awaiting requested review from amika-sq

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

Assignees

@frankhinek frankhinek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename DidUri to Did
3 participants
@frankhinek @LiranCohen @mistermoe