Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sdk-development -> web5-spec #384

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Rename sdk-development -> web5-spec #384

merged 2 commits into from
Jan 25, 2024

Conversation

leordev
Copy link
Contributor

@leordev leordev commented Jan 22, 2024

No description provided.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jan 22, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited
Loading

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

TBDocs Report Updated at 2024-01-22T22:23:54Z 529438c

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited
Loading

Codecov Report

Merging #384 (529438c) into main (25f1d03) will increase coverage by 91.90%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff            @@
##           main     #384       +/-   ##
=========================================
+ Coverage      0   91.90%   +91.90%     
=========================================
  Files         0       67       +67     
  Lines         0    18241    +18241     
  Branches      0     1550     +1550     
=========================================
+ Hits          0    16764    +16764     
- Misses        0     1454     +1454     
- Partials      0       23       +23
Components Coverage Δ
agent 88.71% <ø> (∅)
api 96.94% <ø> (∅)
common 98.57% <ø> (∅)
credentials ∅ <ø> (∅)
crypto 94.60% <ø> (∅)
dids 92.24% <ø> (∅)
identity-agent 56.81% <ø> (∅)
crypto-aws-kms 100.00% <ø> (∅)
proxy-agent 58.43% <ø> (∅)
user-agent 55.22% <ø> (∅)

nitro-neal
nitro-neal reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so instead of web5-spec, the runner will be hosted here -
https://github.com/TBD54566975/sdk-report-runner

nitro-neal
nitro-neal approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to sdk-report-runner and yea should be good to go,

The code at sdk-report-runner may not be ready and an action may fail, but should be up and running soon

@frankhinek
Copy link
Contributor

@finn-tbd IIRC you requested responsibility to migrate the report runner over to the new repo.

What's your ETA? If its not that far out we could hold off on approving this PR until the new sdk-report-runner repo is ready.

frankhinek
frankhinek suggested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@frankhinek frankhinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In last week's Web5 Spec call, it was agreed that sdk-development would be renamed to web5-spec and the report generator / runner would be moved to its own repo. I believe that work is still in progress but will need to be completed and then this PR updated to point to the new repo.

@finn-block
Copy link
Contributor

That was waiting on decentralized-identity/web5-spec#99, which just merged. I believe @nitro-neal is going to handle the rename now as i'm getting pulled into did:dht work

@leordev @nitro-neal
sdk-report-runner
529438c 
Co-authored-by: nitro-neal <[email protected]>
@leordev leordev requested a review from frankhinek January 23, 2024 01:23
@leordev
Copy link
Contributor Author

leordev commented Jan 25, 2024

@frankhinek the changes were addressed, can you please review it again? If it looks good for you, please go ahead and merge!

@frankhinek frankhinek merged commit 2bd93a8 into main Jan 25, 2024
32 checks passed
@frankhinek frankhinek deleted the leordev/ci-web5-spec-fix branch January 25, 2024 17:29
finn-block pushed a commit that referenced this pull request Mar 19, 2024
@leordev @nitro-neal @finn-block
Rename sdk-development -> web5-spec (#384)
4343547 
* Rename Report Runner sdk-development -> sdk-report-runner

Co-authored-by: nitro-neal <[email protected]>
finn-block pushed a commit that referenced this pull request Mar 19, 2024
@leordev @nitro-neal @finn-block
Rename sdk-development -> web5-spec (#384)
d5136a3 
* Rename Report Runner sdk-development -> sdk-report-runner

Co-authored-by: nitro-neal <[email protected]>
finn-block pushed a commit that referenced this pull request Mar 19, 2024
@leordev @nitro-neal @finn-block
Rename sdk-development -> web5-spec (#384)
c7c50af 
* Rename Report Runner sdk-development -> sdk-report-runner

Co-authored-by: nitro-neal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diehuxx diehuxx diehuxx approved these changes

@nitro-neal nitro-neal nitro-neal approved these changes

@frankhinek frankhinek frankhinek approved these changes

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

@mistermoe mistermoe Awaiting requested review from mistermoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leordev @frankhinek @finn-block @nitro-neal @diehuxx