generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve did:dht in VCs #321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoebe-lew
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
November 29, 2023 00:31
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
TBDocs Report ✅ No errors or warnings @web5/api
Updated @ 2023-11-29T00:33:51.834Z - Commit: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 91.77% 91.75% -0.02%
==========================================
Files 73 73
Lines 15758 15758
Branches 1448 1448
==========================================
- Hits 14462 14459 -3
- Misses 1270 1273 +3
Partials 26 26
|
nitro-neal
approved these changes
Nov 29, 2023
@decentralgabe what should use mocks? the test? |
@phoebe-lew sorry disregard, looks good to me 😄 |
mistermoe
approved these changes
Nov 29, 2023
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested via: