Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusting vc.create #311

Merged
merged 2 commits into from
Nov 22, 2023
Merged

adjusting vc.create #311

merged 2 commits into from
Nov 22, 2023

Conversation

nitro-neal
Copy link
Contributor

Addressing this issue:
#301

Old

VerifiableCredential.create('StreetCredibility', 'did:ex:issuer', 'did:ex:subject', { arbitrary: 'data' })

New

VerifiableCredential.create({
  type: 'StreetCredibility',
  issuer: 'did:ex:issuer',
  subject: 'did:ex:subject',
  data: { 'arbitrary': 'data' }
})

Copy link

codesandbox bot commented Nov 22, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Nov 22, 2023

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

Updated @ 2023-11-22T19:26:43.357Z - Commit: 65b724d

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #311 (47817f3) into main (9af892a) will decrease coverage by 0.01%.
The diff coverage is 93.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   90.80%   90.80%   -0.01%     
==========================================
  Files          74       74              
  Lines       14072    14090      +18     
  Branches     1387     1390       +3     
==========================================
+ Hits        12778    12794      +16     
- Misses       1269     1270       +1     
- Partials       25       26       +1     
Components Coverage Δ
api 96.68% <ø> (ø)
common 95.00% <ø> (ø)
credentials 94.32% <93.93%> (-0.18%) ⬇️
crypto 100.00% <ø> (ø)
dids 88.75% <ø> (ø)
agent 88.07% <ø> (ø)
identity-agent 56.81% <ø> (ø)
proxy-agent 58.43% <ø> (ø)
user-agent 55.22% <ø> (ø)

@nitro-neal nitro-neal marked this pull request as ready for review November 22, 2023 19:33
Copy link
Contributor

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@frankhinek frankhinek merged commit da7786d into main Nov 22, 2023
29 of 30 checks passed
@frankhinek frankhinek deleted the adjust-vc-create branch November 22, 2023 20:20
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* adjusting vc.create

* fix spec
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* adjusting vc.create

* fix spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants