fix syncmanager typedefs to use abstractlevel #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report ✅ No errors or warnings @web5/api
Updated @ 2023-11-24T19:29:13.116Z - Commit: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 90.80% 90.78% -0.03%
==========================================
Files 74 74
Lines 14072 14089 +17
Branches 1387 1390 +3
==========================================
+ Hits 12778 12790 +12
- Misses 1269 1273 +4
- Partials 25 26 +1
|
mistermoe
reviewed
Nov 24, 2023
There was a problem hiding this comment.
i thiink the desired convention for imports from top to bottom in this repo (though i'm sure there's evidence of the contrary in a few places bc of time constraints) is:
- all
import types first - then all
imports
There was a problem hiding this comment.
We can probably run a formatter that does this in the future. Although past experience has been that import sorting is always a fail
mistermoe
reviewed
Nov 24, 2023
csuwildcat
approved these changes
Nov 28, 2023
LiranCohen
approved these changes
Nov 28, 2023
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* fix syncmanager to use abstractlevel * fix type * organize imports
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* fix syncmanager to use abstractlevel * fix type * organize imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR
When using typedefs with LevelDB they're meant to adhere to the abstract-level interfaces rather than directly using the typedefs from the
Levelpackage (which is a specific implementation of abstract level).How PR was implemented
Used the same approach as dwn-js-sdk by pulling from the
AbstractLevelinterface and correctly annotating its generics