fix Single-quoted string interpolation in src/web5.ts #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevegee1
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
=======================================
Coverage 90.80% 90.80%
=======================================
Files 74 74
Lines 14072 14072
Branches 1387 1387
=======================================
Hits 12778 12778
Misses 1269 1269
Partials 25 25
|
frankhinek
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Always great to have a new contributor!
Thanks @stevegee1 for catching this and submitting the Issue and PR.
csuwildcat
approved these changes
Nov 20, 2023
frankhinek
merged commit 9af892a
into
decentralized-identity:main
21 of 25 checks passed
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code line: 155
path: path
code snippet:
Issue: static async connect() throws error with
${storedIdentities}treated as literal characters, not as an expression for interpolation.Relsoved issue:
