Fix bug that was causing record.send() and record.update() issues #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report ✅ No errors or warnings @web5/api
Updated @ 2023-11-20T01:29:57.828Z - Commit: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=======================================
Coverage 90.80% 90.80%
=======================================
Files 74 74
Lines 14072 14072
Branches 1387 1387
=======================================
Hits 12778 12778
Misses 1269 1269
Partials 25 25
|
csuwildcat
approved these changes
Nov 20, 2023
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
…300) Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
…300) Signed-off-by: Frank Hinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is primarily a bug fix PR that resolves an issue that was causing
dateModifiedto never be updated after executingrecord.update()and intermittently causedrecord.send()to fail after one or morerecord.update()operations.Context
Several months ago
dwn-sdk-jsPR #419 changed and standardized the naming convention for timestamps across all interfaces. At the time, the decision was made to retain thedateCreatedanddateModifiedproperty names for theRecordmodel used in@web5/api. SinceRecordis a logical representation of a record,dateCreatedmaps to the timestamp when the initialRecordsWritewas created anddateModifiedmaps to the timestamp of the most recent modification.Unfortunately, when
@web5/apiwas updated to reflect this change an update to the list of mutable properties was missed, which resulted in a bug:record.update()operation, themessageTimestampdescriptor property was not updated. As a result, subsequent updates would be written with the samemessageTimestamp.Changes
@web5/apiRecordinstance'smessageTimestampproperty is updated each time a modification is made.record.update()operations not updating the timestamp and to ensure thatrecord.send()succeeded in writing to the remote DWN after multiple rounds ofupdate()/send().