Fix bug with record.data.* after record queries
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
…t is imported from DWN SDK Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
frankhinek
changed the title
record.data.* with record queriesrecord.data.* after record queries
|
TBDocs Report ✅ No errors or warnings @web5/api
Updated @ 2023-11-19T00:27:05.936Z - Commit: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 90.70% 90.80% +0.09%
==========================================
Files 74 74
Lines 14075 14072 -3
Branches 1384 1387 +3
==========================================
+ Hits 12767 12778 +11
+ Misses 1282 1269 -13
+ Partials 26 25 -1
|
mistermoe
approved these changes
Nov 18, 2023
csuwildcat
approved these changes
Nov 18, 2023
Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Improve Type safety now that RecordsReadReply is part of DwnResponse * Improve test coverage by ensuring that the DWN query record size limit is imported from DWN SDK * Fix bug caused by RecordsRead now taking a filter property and add tests
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Improve Type safety now that RecordsReadReply is part of DwnResponse * Improve test coverage by ensuring that the DWN query record size limit is imported from DWN SDK * Fix bug caused by RecordsRead now taking a filter property and add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily a bug fix PR that resolves the following error that was reported by multiple developers:
@web5/agentRecordsReadReplyis part ofDwnResponseand type casting is no longer necessary.@web5/apiRecordsReadswitched to taking a filter property and add tests