Re-introduce resolve Method in DidApi for DID Resolution
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report 🛑 Errors: 0 @web5/api
Updated @ 2023-11-09T20:41:16.408Z - Commit: |
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 90.87% 90.32% -0.55%
==========================================
Files 74 74
Lines 13944 14028 +84
Branches 1379 1382 +3
==========================================
Hits 12671 12671
- Misses 1247 1331 +84
Partials 26 26
|
nitro-neal
reviewed
Nov 8, 2023
nitro-neal
reviewed
Nov 8, 2023
nitro-neal
approved these changes
Nov 8, 2023
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
csuwildcat
approved these changes
Nov 9, 2023
Signed-off-by: Frank Hinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR (re-)introduces the
resolve()method to theDidApiclass, enabling the resolution of DIDs throughweb5.dids.resolve(). The method is designed to be a simple interface for resolving a DID to its corresponding DID Resolution Result, which includes the DID Document.Implementation Details
DidApiclass is equipped with aresolvemethod that takes a DID URL and optional resolution options.Web5Agent, which is expected to handle the actual resolution logic.resolvemethod returns a promise that resolves with theDidResolutionResult.