Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the typo in readme.md #234

Merged

Conversation

captain-Akshay
Copy link
Contributor

fixes issue #233
there were few typo in readme.md:-

"succesfully" should be "successfully."
"imposter" should be "impostor."

Signed-off-by: captain-Akshay <[email protected]>
@codesandbox
Copy link

codesandbox bot commented Oct 2, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@captain-Akshay captain-Akshay changed the title changed the typo fixed the typo in readme.md Oct 2, 2023
@frankhinek
Copy link
Contributor

@captain-Akshay technically both "impostor" and "imposter" are correct ways to spell the word:
https://grammarist.com/spelling/imposter-impostor/#:~:text=The%20noun%20referring%20to%20one,is%20also%20nearly%20as%20old.

but since its 50/50 and the meaning is the same, will merge

@frankhinek frankhinek merged commit e73c548 into decentralized-identity:main Oct 3, 2023
@frankhinek frankhinek linked an issue Oct 3, 2023 that may be closed by this pull request
@EbonyLouis EbonyLouis added the hacktoberfest-accepted Accepted PRs for the hacking month of October label Oct 3, 2023
@captain-Akshay
Copy link
Contributor Author

@EbonyLouis just in case i think you forgot to count this one for the hacktoberfest event ! 😅😅

diehuxx pushed a commit to amika-sq/web5-js that referenced this pull request Oct 30, 2023
* main:
  Did ion: Set assertion method (decentralized-identity#245)
  Update README to reflect dwn-sdk-js 0.2.3 (decentralized-identity#237)
  changed the typo (decentralized-identity#234)
  Upgrade to dwn sdk js v0.2.3 (decentralized-identity#225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted PRs for the hacking month of October
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in README.md
3 participants