Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendDwnRequest returning web Readable #229

Closed
wants to merge 3 commits into from

Conversation

LiranCohen
Copy link
Member

DWNManager has sendRequest and processRequest both return the DwnResponse type.

However sendRequest returns a web Readable as the data property while processRequest returns an isomorphic Readable.

This was causing confusion for me during testing as dealing with the data is different between the two.

I added some tests that around large data payloads in order to test data streams.

@codesandbox
Copy link

codesandbox bot commented Sep 28, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #229 (54cd6e1) into main (a5729b6) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   90.81%   90.80%   -0.02%     
==========================================
  Files          67       67              
  Lines       12838    12839       +1     
  Branches     1268     1268              
==========================================
- Hits        11659    11658       -1     
- Misses       1156     1158       +2     
  Partials       23       23              
Components Coverage Δ
api 94.23% <ø> (-0.09%) ⬇️
common 95.00% <ø> (ø)
credentials 92.77% <ø> (ø)
crypto 100.00% <ø> (ø)
dids 92.16% <ø> (ø)
agent 87.79% <50.00%> (-0.02%) ⬇️
identity-agent 59.05% <ø> (ø)
proxy-agent 58.59% <ø> (ø)
user-agent 57.36% <ø> (ø)

@frankhinek
Copy link
Contributor

Talked to @LiranCohen about this PR yesterday and he's going to review and determine whether it should be closed or taken out of Draft state for review.

@frankhinek
Copy link
Contributor

@LiranCohen said he'll re-open later once ready for review

@frankhinek frankhinek closed this Jan 16, 2024
@LiranCohen LiranCohen deleted the lirancohen/isomorphic-data-stream branch April 1, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants