sendDwnRequest returning web Readable #229
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DWNManager
hassendRequest
andprocessRequest
both return theDwnResponse
type.However
sendRequest
returns a web Readable as thedata
property whileprocessRequest
returns an isomorphic Readable.This was causing confusion for me during testing as dealing with the data is different between the two.
I added some tests that around large data payloads in order to test data streams.