-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding subscriptions to web5-js #228
adding subscriptions to web5-js #228
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
3786401
to
e6ee17a
Compare
@finn-tbd trying to test this locally, and running into some issues due to all the updates to authorization in One of many errors thrown just for additional context: tests/record.spec.ts:466:100 - error TS2322: Type '{ recordId: string; }' is not assignable to type 'Omit<RecordsReadOptions, "authorizationSignatureInput">'.
Object literal may only specify known properties, and 'recordId' does not exist in type 'Omit<RecordsReadOptions, "authorizationSignatureInput">'.
466 const { record: readRecord, status: readRecordStatus } = await dwn.records.read({ message: { recordId: record!.id }});
~~~~~~~~```
```sh
Found 32 errors in 4 files. Seems like the signer updates is more or less straightforward. There are some other broken pieces though a lot more involved. |
Looks like @thehenrytsai made these changes to dwn-sdk-js. Maybe he knows the answer? |
update web5 subscription filter
Still in Draft state. @andorsk any update on timing for this? |
@frankhinek haven't tested this in a while, but this was blocked by two things:
|
@LiranCohen requested keeping open for now as a reminder to circle back and continue work |
Closing in favor of: #433 |
initial subscriptions PR. Do NOT merge, but used for transparency to show some of the API's and interfaces design for users when using the subscriptions interface. Open for feedback and discussion. Will have some updates in the near future.
See the documentation here: https://github.com/getZION/web5-js/tree/ask/subscription/packages/api#web5dwnsubscriptioncreaterequest for intended use.