Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@web5/dids add missing dependency #203

Merged
merged 1 commit into from
Aug 28, 2023
Merged

@web5/dids add missing dependency #203

merged 1 commit into from
Aug 28, 2023

Conversation

mistermoe
Copy link
Contributor

The following error occurs when attempting to use a package that has @web5/dids as a dependency:

node:internal/errors:496
    ErrorCaptureStackTrace(err);
    ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'ms' imported from /Users/moe/code/tmp/try-tbdex/node_modules/@web5/dids/dist/esm/resolver-cache-level.js
    at new NodeError (node:internal/errors:405:5)
    at packageResolve (node:internal/modules/esm/resolve:782:9)
    at moduleResolve (node:internal/modules/esm/resolve:831:20)
    at defaultResolve (node:internal/modules/esm/resolve:1036:11)
    at DefaultModuleLoader.resolve (node:internal/modules/esm/loader:251:12)
    at DefaultModuleLoader.getModuleJob (node:internal/modules/esm/loader:140:32)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:33)
    at link (node:internal/modules/esm/module_job:75:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

This PR adds ms as a dependency for @web5/dids

@mistermoe mistermoe changed the base branch from v0.7.11 to main August 28, 2023 20:37
Copy link
Contributor

@frankhinek frankhinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistermoe mistermoe merged commit 8204a49 into main Aug 28, 2023
@frankhinek frankhinek deleted the dids-missing-dep branch September 1, 2023 00:46
andorsk pushed a commit to modernfoundry/web5-js that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants