Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native directives to each package.json #137

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

amika-sq
Copy link
Contributor

In React Native, the directive priority order goes:
react-native > browser > main

The react-native directive was previously not present, so it would instead use the values from the browser directive. This caused react native to consume ./dist/browser.js, which causes issues in that environment. This required workarounds in react native apps that consume it.

To fix, this PR directly sets values for ./dist/esm/src/index.js and ./dist/cjs/src/index.js to always point to the esm version.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #137 (b700a30) into main (69ab8a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   64.74%   64.74%           
=======================================
  Files          33       33           
  Lines        3551     3551           
  Branches      198      198           
=======================================
  Hits         2299     2299           
  Misses       1250     1250           
  Partials        2        2           
Components Coverage Δ
common 0.00% <ø> (ø)
credentials 0.00% <ø> (ø)
crypto 0.00% <ø> (ø)
dids 48.61% <ø> (ø)
web5 81.51% <ø> (ø)
web5-agent 0.00% <ø> (ø)
web5-proxy-agent 0.00% <ø> (ø)
web5-user-agent 79.60% <ø> (ø)

@frankhinek frankhinek merged commit 1ecb992 into decentralized-identity:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants