Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ion-tools and dwn-sdk-js dependencies to latest version #134

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

thehenrytsai
Copy link
Contributor

Debugged the couple of failed tests and it traced down to incompatibility introduced in protocols in dwn-sdk-js currently deployedd. Will need to update the dwn-server and get it deployed tomorrow.

Copy link
Contributor

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best

@frankhinek
Copy link
Contributor

frankhinek commented Jun 23, 2023

@thehenrytsai if you rebase on main, you can pull in the fix in PR #136 for the semver security vulnerability that was causing this PR to fail the security audit check.

And then we'll have to address whatever is causing the record.send() tests to fail.

@thehenrytsai thehenrytsai force-pushed the henrytsai/dependencies-2023-06-22 branch from 5402450 to e9e90e1 Compare June 23, 2023 18:38
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #134 (e9e90e1) into main (763c157) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   64.74%   64.74%           
=======================================
  Files          33       33           
  Lines        3551     3551           
  Branches      198      198           
=======================================
  Hits         2299     2299           
  Misses       1250     1250           
  Partials        2        2           
Components Coverage Δ
common 0.00% <ø> (ø)
credentials 0.00% <ø> (ø)
crypto 0.00% <ø> (ø)
dids 48.61% <ø> (ø)
web5 81.51% <ø> (ø)
web5-agent 0.00% <ø> (ø)
web5-proxy-agent 0.00% <ø> (ø)
web5-user-agent 79.60% <ø> (ø)

@thehenrytsai thehenrytsai merged commit 69ab8a5 into main Jun 23, 2023
@thehenrytsai thehenrytsai deleted the henrytsai/dependencies-2023-06-22 branch June 23, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants