corrected field name on protocols.configure() #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angiejones
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 66.05% 66.05%
=======================================
Files 31 31
Lines 3456 3456
Branches 195 195
=======================================
Hits 2283 2283
Misses 1171 1171
Partials 2 2
|
frankhinek
reviewed
Jun 12, 2023
| @@ -325,7 +325,7 @@ The `configure` request object is composed as follows: | |||
| - **`protocol`** - _`URI string`_: a URI that represents the protocol being configured. | |||
| - **`types`** - _`object`_: an object that defines the records that can be used in the `structure` graph of the `definition` object. The following properties are optional constraints you can set for the type being defined: | |||
| - **`schema`** - _`URI string`_ (_optional_): the URI of the schema under which the record will be bucketed. | |||
| - **`dataFormat`** - _`Media Type string`_ (_optional_): the IANA string corresponding with the format of the data the record will be bucketed. See IANA's Media Type list here: https://www.iana.org/assignments/media-types/media-types.xhtml | |||
| - **`dataFormats`** - _`Media Type string[]`_ (_optional_): Array of the IANA strings corresponding with the formats of the data the record will be bucketed. See IANA's Media Type list here: https://www.iana.org/assignments/media-types/media-types.xhtml | |||
There was a problem hiding this comment.
@csuwildcat does "bucketed" make sense to use in the case of describing the purpose of dataFormats specified as a constraint on prototype types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed
dataFormat:stringtodataFormats:string[]based onProtocolType: