Fix eslint NPM scripts and migrate to root .eslintrc config #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 65.97% 66.05% +0.08%
==========================================
Files 31 31
Lines 3447 3456 +9
Branches 195 195
==========================================
+ Hits 2274 2283 +9
Misses 1171 1171
Partials 2 2
|
mistermoe
approved these changes
Jun 9, 2023
Merged
mistermoe
reviewed
Jun 10, 2023
| @@ -12,6 +13,10 @@ module.exports = { | |||
| es2022 : true, | |||
| browser : true | |||
| }, | |||
| 'ignorePatterns': [ | |||
There was a problem hiding this comment.
nice find as a replaceent for .eslintignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
Correct
lintandlint:fixNPM scripts to use.tsinstead of.jssince project was refactored to TypeScript:https://github.com/TBD54566975/web5-js/blob/5a8e8e3ddc94a6908fe840de6fbfc763ec33f62d/packages/web5/package.json#L11-L12
Migrate to a single root
.eslintrc.cjssince all 6 of the existing packages had identical ESLint config files. If different rules are needed in the future, we can always add a project specific config that extends and modifies the configuration.Added
eslint.workingDirectoriessetting to VSCode Workspace which is recommended by MSFT to ensure VSCode knows the appropriate CWD to run ESLint from.