review comments for delegateDid, update dwn-server to latest

decentralized-identity · Aug 14, 2024 · c65f479 · c65f479
1 parent 886c9bc
commit c65f479
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 19 deletions.
diff --git a/packages/api/src/web5.ts b/packages/api/src/web5.ts
@@ -142,9 +142,6 @@ export type Web5ConnectResult = {
   /** The DID that has been connected or created during the connection process. */
   did: string;
 
-  /** The DID that is used to sign messages on behalf of the connectedDID */
-  delegatedDid?: string;
-
   /**
    * The first time a Web5 agent is initialized, the recovery phrase that was used to generate the
    * agent's DID and keys is returned. This phrase can be used to recover the agent's vault contents

diff --git a/packages/api/tests/web5.spec.ts b/packages/api/tests/web5.spec.ts
@@ -557,8 +557,8 @@ describe('web5 api', () => {
         // stub the walletInit method
         sinon.stub(WalletConnect, 'initClient').resolves({
           delegateGrants : [ writeGrant.dataEncodedMessage, readGrant.dataEncodedMessage ],
-          delegateDid: await app.export(),
-          connectedDid    : alice.did.uri
+          delegateDid    : await app.export(),
+          connectedDid   : alice.did.uri
         });
 
         const appTestHarness = await PlatformAgentTestHarness.setup({
@@ -575,11 +575,11 @@ describe('web5 api', () => {
         // connect to the app, the options don't matter because we're stubbing the initClient method
         const { web5, did, delegateDid } = await Web5.connect({
           walletConnectOptions: {
-            connectServerUrl            : 'https://connect.example.com',
-            walletUri                   : 'https://wallet.example.com',
-            validatePin                 : async () => { return '1234'; },
-            onWalletUriReady            : (_walletUri: string) => {},
-            permissionRequests          : [],
+            connectServerUrl   : 'https://connect.example.com',
+            walletUri          : 'https://wallet.example.com',
+            validatePin        : async () => { return '1234'; },
+            onWalletUriReady   : (_walletUri: string) => {},
+            permissionRequests : [],
           }
         });
         expect(web5).to.exist;
@@ -719,9 +719,9 @@ describe('web5 api', () => {
         expect(queryResult.records).to.have.lengthOf(0); // record has been deleted
 
         // connecting a 2nd time will return the same connectedDID and delegatedDID
-        const { did: did2, delegatedDid: delegatedDid2 } = await Web5.connect();
+        const { did: did2, delegateDid: delegateDid2 } = await Web5.connect();
         expect(did2).to.equal(did);
-        expect(delegatedDid2).to.equal(delegatedDid);
+        expect(delegateDid2).to.equal(delegateDid);
 
         // Close the app test harness storage.
         await appTestHarness.clearStorage();
@@ -811,8 +811,8 @@ describe('web5 api', () => {
         // stub the walletInit method of the Connect placeholder class
         sinon.stub(WalletConnect, 'initClient').resolves({
           delegateGrants : [ writeGrant.dataEncodedMessage, readGrant.dataEncodedMessage ],
-          delegateDid     : await app.export(),
-          connectedDid    : alice.did.uri
+          delegateDid    : await app.export(),
+          connectedDid   : alice.did.uri
         });
 
         const appTestHarness = await PlatformAgentTestHarness.setup({
@@ -840,11 +840,11 @@ describe('web5 api', () => {
           // connect to the app, the options don't matter because we're stubbing the initClient method
           await Web5.connect({
             walletConnectOptions: {
-              connectServerUrl            : 'https://connect.example.com',
-              walletUri                   : 'https://wallet.example.com',
-              validatePin                 : async () => { return '1234'; },
-              onWalletUriReady            : (_walletUri: string) => {},
-              permissionRequests          : []
+              connectServerUrl   : 'https://connect.example.com',
+              walletUri          : 'https://wallet.example.com',
+              validatePin        : async () => { return '1234'; },
+              onWalletUriReady   : (_walletUri: string) => {},
+              permissionRequests : []
             }
           });