Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ION DID Provider and Resolver Implementation #440

Closed
wants to merge 7 commits into from
Closed

Conversation

rado0x54
Copy link
Contributor

@rado0x54 rado0x54 commented Mar 31, 2021

This branch provides support for did:ion in veramo.

Do not merge prior to the following issues being resolved:

  • JWK Key handling in Veramo
  • 50 char Key ID restriction in ION / key.kid in Veramo
  • Transmute did-key dependencies for tooling (transitive in ion-tools)
  • General dependency bloat: yarn.lock ++ 4000 lines.
  • Source for verificationMethodTypes et al.
  • ion-tools currently only supports create operation

Relates to #336

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #440 (17e28cc) into next (88264db) will decrease coverage by 2.91%.
The diff coverage is 44.88%.

❗ Current head 17e28cc differs from pull request most recent head 17178fe. Consider uploading reports for the commit 17178fe to get more accurate results

@@            Coverage Diff             @@
##             next     #440      +/-   ##
==========================================
- Coverage   67.58%   64.67%   -2.92%     
==========================================
  Files          62       74      +12     
  Lines        1530     1704     +174     
  Branches      247      277      +30     
==========================================
+ Hits         1034     1102      +68     
- Misses        400      496      +96     
- Partials       96      106      +10     

@rado0x54
Copy link
Contributor Author

Relates to #336

@rado0x54
Copy link
Contributor Author

The full ion-tools support is effectively blocked by decentralized-identity/ion-tools#3 (Lack of update functionality)

@stale
Copy link

stale bot commented Aug 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 28, 2021
@stale stale bot closed this Sep 6, 2021
@mikhael28
Copy link

@rado0x54 as an FYI, this support was added in (at least according the csuwildcat) in that GitHub issue you mention from decentralized identity.

@mirceanis mirceanis removed the wontfix This will not be worked on label Apr 6, 2022
@mirceanis mirceanis reopened this Apr 6, 2022
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 31, 2022
@mirceanis mirceanis added the pinned don't close this just for being stale label Jul 31, 2022
@nklomp
Copy link
Member

nklomp commented Aug 5, 2022

Just wanted to let you know we are working on creating a full implementation that supports recovery and updates, as well as generating keys on the fly and importing keys. It started out as a fork of this PR, as we need it for certain projects. But right now we need to have a fully working implementation soon. After the work in the URL is complete, we will create a PR to merge it into Veramo directly.

Next to the remaining work, there is a big issue currently with getting everything to work in React-Native. We had to fork several ION packages to get it to work. After the full implementation we will solve these ports in a nicer way as well.

If you are curious
https://github.com/Sphereon-Opensource/ssi-sdk/tree/feature/WAL-246/packages/ion-did-provider

@stale stale bot removed the wontfix This will not be worked on label Aug 5, 2022
@nklomp nklomp mentioned this pull request Aug 10, 2022
6 tasks
@nklomp
Copy link
Member

nklomp commented Aug 24, 2022

Probably it makes sense to close this PR, as it is superseded by #987

@mirceanis
Copy link
Member

Correct, thanks for flagging it!

@mirceanis mirceanis closed this Aug 24, 2022
mirceanis pushed a commit that referenced this pull request Oct 10, 2022
@mirceanis mirceanis deleted the feature/ion branch October 31, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned don't close this just for being stale work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants