Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simpler create VC/VP #309

Merged
merged 1 commit into from
Dec 17, 2020
Merged

feat: Simpler create VC/VP #309

merged 1 commit into from
Dec 17, 2020

Conversation

simonas-notcat
Copy link
Contributor

This was branched of rename branch. Only the last commit matters here

@mirceanis mirceanis force-pushed the feature/create-vc-vp branch from 2d857e3 to 11ae100 Compare December 17, 2020 18:09
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #309 (11ae100) into beta (7812e51) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             beta     #309      +/-   ##
==========================================
+ Coverage   68.21%   68.38%   +0.16%     
==========================================
  Files          62       62              
  Lines        1504     1512       +8     
  Branches      237      243       +6     
==========================================
+ Hits         1026     1034       +8     
  Misses        382      382              
  Partials       96       96              

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mirceanis mirceanis merged commit 172c908 into beta Dec 17, 2020
@mirceanis mirceanis deleted the feature/create-vc-vp branch December 17, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants