fix(message-handler): Rewire promise rejections as Error
objects and
#300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #294
The actual fix is renaming the error event to
ev_err
instead oferror
.During this fix, I also "standardised" the way errors are thrown or rejections called.
The bottom line is always use an
Error
object.It makes things more consistent and also easier to test.
This will be enforced with a rule like no-throw-literal when we turn linting back on.