Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credential-w3c): list usable proof formats for an IIdentifier #1268

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mirceanis
Copy link
Member

What is being changed

The CredentialPlugin now exports a new method listUsableProofFormats() that can be used to decide which type of proofFormat can be requested for creating a credential or presentation.
It queries the other available credential plugins to check if the keys of a DID are usable with them and also relies on the metadata provided by key management systems in its decision.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (93198bc) 84.99% compared to head (acc40e4) 84.99%.
Report is 4 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1268      +/-   ##
==========================================
- Coverage   84.99%   84.99%   -0.01%     
==========================================
  Files         167      167              
  Lines       18001    18137     +136     
  Branches     2009     2039      +30     
==========================================
+ Hits        15300    15415     +115     
- Misses       2701     2722      +21     
Files Coverage Δ
packages/core/src/agent.ts 99.25% <100.00%> (ø)
...es/credential-eip712/src/agent/CredentialEIP712.ts 91.68% <100.00%> (+0.36%) ⬆️
packages/credential-ld/src/action-handler.ts 89.58% <100.00%> (+0.99%) ⬆️
packages/credential-ld/src/types.ts 100.00% <100.00%> (ø)
packages/credential-w3c/src/action-handler.ts 83.18% <96.00%> (+1.18%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nickreynolds nickreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@mirceanis mirceanis merged commit e94aaf2 into next Oct 5, 2023
@mirceanis mirceanis deleted the supported-vc-formats branch October 5, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants