Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): add @veramo/credential-ld to the CLI dependencies #1043

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

mirceanis
Copy link
Member

fixes #1042

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran yarn, yarn build, yarn test, yarn test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because no functionality has changed.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1043 (ccdeda1) into next (125bf42) will increase coverage by 0.68%.
The diff coverage is 83.56%.

❗ Current head ccdeda1 differs from pull request most recent head 4372bcc. Consider uploading reports for the commit 4372bcc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1043      +/-   ##
==========================================
+ Coverage   80.25%   80.93%   +0.68%     
==========================================
  Files         118      124       +6     
  Lines        4056     4533     +477     
  Branches      875      971      +96     
==========================================
+ Hits         3255     3669     +414     
- Misses        798      861      +63     
  Partials        3        3              

@mirceanis mirceanis merged commit 0698185 into next Oct 25, 2022
@mirceanis mirceanis deleted the 1042-cli-transitive-dependencies branch October 25, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @veramo/cli default config uses credential-ld but does not install it.
2 participants