Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MessageHandler for handling DIDCommV2 envelopes #469

Closed
awoie opened this issue Apr 20, 2021 · 2 comments · Fixed by #610
Closed

Implement MessageHandler for handling DIDCommV2 envelopes #469

awoie opened this issue Apr 20, 2021 · 2 comments · Fixed by #610
Assignees
@awoie
Milestone
messaging-phase1

Comments

@awoie
Copy link
Member

awoie commented Apr 20, 2021

DIDCommV2 messages are identified by their cty and can have different forms:

  • JWM (JWE) with ECDH-1PU --> needs to be decrypted with agents private key and needs to resolve public key of recipient
  • JWM (JWS) with EdDSA/ES256K --> needs to be verified
  • Plaintext

JWE and JWS are in JSON general serialization, NOT compact serialization

No threaded protocol support needed.

handleMessage should still emit the event validatedMessage in case everything went correctly
@awoie awoie added this to the messaging-phase1 milestone Apr 26, 2021
@awoie awoie self-assigned this Jun 7, 2021
@mirceanis
Copy link
Member

@awoie please track the JWS & plaintext cases separately

@awoie
Copy link
Member Author

awoie commented Jun 30, 2021

implemented but integration tests are missing: https://github.com/uport-project/veramo/blob/feat/add-didcomm-v2

@awoie awoie mentioned this issue Jul 8, 2021
Merged
mirceanis added a commit that referenced this issue Jul 8, 2021
@awoie @mirceanis @simonas-notcat
feat: add support for did-comm over simple HTTP-based transports (#610)
78836a4 
fixes #552
fixes #469

* feat: add sending didcomm messages
* feat: add transport logic
* fix(did-comm): message handler
* docs: add more inline documentation for did-comm
* fix: use http transport by default with didcomm
* test(did-comm): integration test for sending data
* test(did-comm): check didcomm events
* style: refactoring and code reformatting

Co-authored-by: Oliver Terbu <>
Co-authored-by: Mircea Nistor <[email protected]>
Co-authored-by: Simonas Karuzas <[email protected]>
@mirceanis mirceanis mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awoie awoie

Labels
None yet
Projects
None yet
Milestone
messaging-phase1
2 participants
@mirceanis @awoie