Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #269, #272 & #166 - Implemented protocol versioning support with backward compatibility #273

Merged
merged 8 commits into from
Aug 15, 2019

Conversation

thehenrytsai
Copy link
Collaborator

@OR13
Copy link
Contributor

OR13 commented Aug 13, 2019

This is a massive PR :)

@thehenrytsai
Copy link
Collaborator Author

This is a massive PR :)

Yeah.... sorry, I am personally totally against massive PRs... but unfortunately this had to be done as one. Core logic remains identical, the changes mainly evolves around how components are initialized and versioned. I am working on a documenting the versioning strategy in the implementation doc right now, will push that out shortly.

@thehenrytsai thehenrytsai merged commit 7d66cf5 into master Aug 15, 2019
@thehenrytsai thehenrytsai deleted the henrytsai/269 branch August 15, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants