Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed possible dangerous application of Regex in examples #448

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fixed possible dangerous application of Regex in examples #448

merged 1 commit into from
Oct 5, 2023

Conversation

rado0x54
Copy link
Contributor

@rado0x54 rado0x54 commented Oct 5, 2023 •
edited
Loading

Used more strict Regex on Presentation Definition Examples

Fixes #428

nklomp
nklomp reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo these examples should move to constants instead of regexes for the most part. Regexes are being used to check fixed values here.

@csuwildcat csuwildcat merged commit 1c24b0b into main Oct 5, 2023
@bumblefudge bumblefudge mentioned this pull request Oct 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nklomp nklomp nklomp left review comments

@OR13 OR13 OR13 approved these changes

@csuwildcat csuwildcat csuwildcat approved these changes

@kimdhamilton kimdhamilton Awaiting requested review from kimdhamilton kimdhamilton is a code owner

@brentzundel brentzundel Awaiting requested review from brentzundel brentzundel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong use of pattern in examples
4 participants
@rado0x54 @csuwildcat @OR13 @nklomp