Fixed bug where number type is too small for unix epoch in some SQL variants
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
mistermoe,
LiranCohen,
frankhinek and
csuwildcat
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 87.36% 87.45% +0.08%
==========================================
Files 12 12
Lines 1504 1514 +10
Branches 219 221 +2
==========================================
+ Hits 1314 1324 +10
Misses 190 190 |
thehenrytsai
changed the title
number type is too small for unix epoch in some SQL variants
LiranCohen
reviewed
Jul 1, 2024
LiranCohen
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numbertype is too small for unix epoch in some SQL variantsdwn-sdk-jstest suite forReumsableTaskStore(the reason why the bug was not caught)bigint