-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol Interface Permissions #803
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 98.70% 98.71% +0.01%
==========================================
Files 73 74 +1
Lines 11335 11469 +134
Branches 1631 1652 +21
==========================================
+ Hits 11188 11322 +134
Misses 141 141
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legit! Just a couple of nits and questions.
Co-authored-by: Henry Tsai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐 🐐 🐐
ProtocolConfigure
ProtocolPermissionScope
to be scoped down to a specific protocolRecord
util class toMessage
core class.When DWAs request permissions, they will now be issued a
ProtocolsQuery
permission scoped to the protocol they are being authorized, as well as optionally aProtocolsConfigure
for that protocol.Satisfies:
#801
#802