Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved typing of PermissionGrant.parse() to avoid misuse #760

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

thehenrytsai
Copy link
Contributor

  1. Improved typing of PermissionGrant.parse() to avoid misuse
  2. Detected and fixed a couple of unimportant misuses in the tests after the above change (case in point).

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (158470f) to head (2d5cf5f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
+ Coverage   98.57%   98.64%   +0.07%     
==========================================
  Files          73       73              
  Lines       10986    10987       +1     
  Branches     1582     1585       +3     
==========================================
+ Hits        10829    10838       +9     
+ Misses        151      143       -8     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🙇

@thehenrytsai thehenrytsai merged commit b1ea021 into main Jun 15, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/improved-permission-typing branch June 15, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants