Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecordsPermissionScope Requests must be scoped to a protocol #753

Merged
merged 8 commits into from
Jun 13, 2024
Merged

RecordsPermissionScope Requests must be scoped to a protocol #753

merged 8 commits into from
Jun 13, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Jun 12, 2024 •
edited
Loading

Enforce RecordsPermissionScope validation on createGrant

@LiranCohen LiranCohen force-pushed the lirancohen/protocol-scoped-permissions-request branch from f03849f to d51bb62 Compare June 13, 2024 18:19
Base automatically changed from lirancohen/protocol-scoped-grants to main June 13, 2024 19:04
@LiranCohen LiranCohen force-pushed the lirancohen/protocol-scoped-permissions-request branch from 61297c9 to 4e911a2 Compare June 13, 2024 19:04
@LiranCohen LiranCohen force-pushed the lirancohen/protocol-scoped-permissions-request branch from 4e911a2 to 93ef1b9 Compare June 13, 2024 19:13
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (661fad2) to head (45ab0dd).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files          73       73           
  Lines       10910    10929   +19     
  Branches     1571     1573    +2     
=======================================
+ Hits        10752    10771   +19     
  Misses        152      152           
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiranCohen LiranCohen marked this pull request as ready for review June 13, 2024 20:10
@LiranCohen LiranCohen force-pushed the lirancohen/protocol-scoped-permissions-request branch from 8c88313 to 45ab0dd Compare June 13, 2024 20:23
thehenrytsai
thehenrytsai approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 🎸 🚀

And thanks for noticing and fixing missing await tests!

@LiranCohen LiranCohen merged commit 94da019 into main Jun 13, 2024
4 checks passed
@LiranCohen LiranCohen deleted the lirancohen/protocol-scoped-permissions-request branch June 13, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehenrytsai thehenrytsai thehenrytsai approved these changes

@csuwildcat csuwildcat csuwildcat approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiranCohen @codecov-commenter @csuwildcat @thehenrytsai