Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests to demonstrate direct child-role authorization in slack-like protocol #696

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Added tests to demonstrate direct child-role authorization in slack-like protocol #696

merged 2 commits into from
Feb 27, 2024

Conversation

thehenrytsai
Copy link
Contributor

No description provided.

LiranCohen
LiranCohen suggested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just forgot the .only in the test.

tests/scenarios/nested-roles.spec.ts Outdated Show resolved Hide resolved
@thehenrytsai thehenrytsai merged commit f7c8d85 into main Feb 27, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/child-role-tests branch February 27, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiranCohen LiranCohen LiranCohen approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thehenrytsai @LiranCohen