Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced existing DID resolution library with @web5/dids #673

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

thehenrytsai
Copy link
Contributor

  • Replaced existing DID resolution library with @web5/dids
  • Added did:dht support

Copy link

codesandbox bot commented Jan 25, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f6e01e) 98.82% compared to head (524b5ea) 98.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   98.82%   98.79%   -0.04%     
==========================================
  Files          77       74       -3     
  Lines       10015     9758     -257     
  Branches     1465     1432      -33     
==========================================
- Hits         9897     9640     -257     
- Misses        110      112       +2     
+ Partials        8        6       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LiranCohen
LiranCohen previously approved these changes Jan 25, 2024
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

README.md Outdated Show resolved Hide resolved
src/handlers/events-query.ts Show resolved Hide resolved
tests/handlers/permissions-request.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thehenrytsai thehenrytsai merged commit 31f5e29 into main Jan 25, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/web5-dids branch January 25, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants