Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace paginationMessageCid with cursor for pagination query options and response. #608

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

LiranCohen
Copy link
Member

When bubbling up this change into web5-js @frankhinek had a comment about a more intuitive developer experience.
decentralized-identity/web5-js#268 (comment)

I know we originally wanted to be explicit with what the cursor value should be, but I think that it's more appropriate for the spec rather than the naming of the variable.

@thehenrytsai what are your thoughts here?

Copy link

codesandbox bot commented Nov 14, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f97000a) 98.55% compared to head (88e3cf1) 98.55%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files          67       67           
  Lines        8328     8328           
  Branches     1213     1213           
=======================================
  Hits         8208     8208           
  Misses        114      114           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiranCohen LiranCohen merged commit 3f8b405 into main Nov 14, 2023
4 checks passed
@LiranCohen LiranCohen deleted the lirancohen/pagination-cursor branch November 14, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants