generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event and Records Subscriptions #607
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ace20b7
Squashed commit of record and event subscriptions base.
LiranCohen 3df786f
slight refactor
LiranCohen f655395
add timeouts to tests
LiranCohen 4fb69d5
test delegate grant
LiranCohen d20624a
signal when record is updated
LiranCohen c356440
update notifier signature
LiranCohen f4a94d5
handler signature should just be the incoming message, ignoring previ…
LiranCohen 7d62034
update tests and comments
LiranCohen aed0baa
update events filters
LiranCohen 3a9f5fb
refactor EventStream interface, added new test scaffolding
LiranCohen 4fef1c2
add error handler to records subscription
LiranCohen c120086
remove uneeded event subsribe testing until delegating eEventsQuery/G…
LiranCohen 942ceec
add error handling to general subscriptions
LiranCohen d15427f
emit unknown error
LiranCohen 14f2cd2
fix circular deps
LiranCohen f49e516
update interface naming and add comments
LiranCohen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"$id": "https://identity.foundation/dwn/json-schemas/events-subscribe.json", | ||
"type": "object", | ||
"additionalProperties": false, | ||
"required": [ | ||
"descriptor" | ||
], | ||
"properties": { | ||
"authorization": { | ||
"$ref": "https://identity.foundation/dwn/json-schemas/authorization.json" | ||
}, | ||
"descriptor": { | ||
"type": "object", | ||
"additionalProperties": false, | ||
"required": [ | ||
"interface", | ||
"method", | ||
"messageTimestamp", | ||
"filters" | ||
], | ||
"properties": { | ||
"interface": { | ||
"enum": [ | ||
"Events" | ||
], | ||
"type": "string" | ||
}, | ||
"method": { | ||
"enum": [ | ||
"Subscribe" | ||
], | ||
"type": "string" | ||
}, | ||
"messageTimestamp": { | ||
"type": "string" | ||
}, | ||
"filters": { | ||
"type": "array", | ||
"items": { | ||
"$ref": "https://identity.foundation/dwn/json-schemas/events-filter.json" | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,6 +66,7 @@ | |
"enum": [ | ||
"delete", | ||
"query", | ||
"subscribe", | ||
"read", | ||
"update", | ||
"write" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"$id": "https://identity.foundation/dwn/json-schemas/records-subscribe.json", | ||
"type": "object", | ||
"additionalProperties": false, | ||
"required": [ | ||
"descriptor" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sanity: |
||
], | ||
"properties": { | ||
"authorization": { | ||
"$ref": "https://identity.foundation/dwn/json-schemas/authorization-delegated-grant.json" | ||
}, | ||
"descriptor": { | ||
"type": "object", | ||
"additionalProperties": false, | ||
"required": [ | ||
"interface", | ||
"method", | ||
"messageTimestamp", | ||
"filter" | ||
], | ||
"properties": { | ||
"interface": { | ||
"enum": [ | ||
"Records" | ||
], | ||
"type": "string" | ||
}, | ||
"method": { | ||
"enum": [ | ||
"Subscribe" | ||
], | ||
"type": "string" | ||
}, | ||
"messageTimestamp": { | ||
"$ref": "https://identity.foundation/dwn/json-schemas/defs.json#/definitions/date-time" | ||
}, | ||
"filter": { | ||
"$ref": "https://identity.foundation/dwn/json-schemas/records-filter.json" | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanity:
authorization
is required also no?