Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#564 - Added delegated grant support for RecordsRead #605

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

thehenrytsai
Copy link
Contributor

No description provided.

Copy link

codesandbox bot commented Nov 10, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2023

Codecov Report

Merging #605 (5e7b494) into main (f97000a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files          67       68    +1     
  Lines        8328     8329    +1     
  Branches     1213     1211    -2     
=======================================
+ Hits         8208     8209    +1     
  Misses        114      114           
  Partials        6        6           
Files Coverage Δ
src/core/abstract-message.ts 100.00% <100.00%> (ø)
src/core/dwn-error.ts 100.00% <100.00%> (ø)
src/core/grant-authorization.ts 100.00% <100.00%> (ø)
src/core/message.ts 100.00% <100.00%> (ø)
src/core/protocol-authorization.ts 99.41% <100.00%> (+<0.01%) ⬆️
src/interfaces/events-get.ts 97.67% <100.00%> (+0.05%) ⬆️
src/interfaces/messages-get.ts 98.30% <100.00%> (+0.02%) ⬆️
src/interfaces/permissions-grant.ts 100.00% <100.00%> (ø)
src/interfaces/permissions-request.ts 100.00% <100.00%> (ø)
src/interfaces/permissions-revoke.ts 100.00% <100.00%> (ø)
... and 7 more

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Nice abstraction, should help make things clean for other interfaces also.

src/interfaces/records-write.ts Show resolved Hide resolved
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thehenrytsai thehenrytsai merged commit 947a372 into main Nov 14, 2023
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/564-read branch November 14, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants