Remove circular dependency causing problems in lib consumer #598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some circular dependencies in
dwn-sdk-js
that we should consider removing/resolving. One circular dependency in particular is causing issues in consumers ofdwn-sdk-js
.In this PR
dwn-sql-store
, we are getting the following error upon running tests:This culprit is importing
index.js
ined25519.ts
in this PR: https://github.com/TBD54566975/dwn-sdk-js/pull/591/files#diff-1b59382673e9e3dc1c3ec5cc4aebccb275379aa957877a6c0bdf8a6d2cadfcc0R5Importing directly from
dwn-error.ts
instead ofindex.js
fixed the error indwn-sql-store
.