Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario test for a multi-party encrypted chat app #556

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Scenario test for a multi-party encrypted chat app #556

merged 3 commits into from
Oct 12, 2023

Conversation

thehenrytsai
Copy link
Contributor

@thehenrytsai thehenrytsai commented Oct 11, 2023 •
edited
Loading

  • Wrote a scenario test for a multi-party chat app that make use of:
    • Role-based authorization for chat thread participants
    • Protocol context derived key for chat thread encryption
    • Participant protocol path derived key for context derived private key encryption
  • Other minor improvements and fixes

@codesandbox
Copy link

codesandbox bot commented Oct 11, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

LiranCohen
LiranCohen previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nits. Looks good.

tests/end-to-end-tests.spec.ts Outdated Show resolved Hide resolved
tests/end-to-end-tests.spec.ts Outdated Show resolved Hide resolved
tests/end-to-end-tests.spec.ts Outdated Show resolved Hide resolved
@thehenrytsai thehenrytsai merged commit 72c2130 into main Oct 12, 2023
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/multi-party-chat branch October 12, 2023 21:04
diehuxx pushed a commit that referenced this pull request Oct 13, 2023
Merge branch 'main' into diehuxx/protocol-record-validation
c53e41b 
* main:
  Overload type signature for processMessage (#554)
  Scenario test for a multi-party encrypted chat app (#556)
  Update ProtocolsQueryReply type to reflect actual object returned (#551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diehuxx diehuxx diehuxx approved these changes

@LiranCohen LiranCohen LiranCohen approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thehenrytsai @LiranCohen @diehuxx