Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump transitive dependencies to latest along with ion-tools #315

Closed
1 of 3 tasks
shamilovtim opened this issue Apr 18, 2023 · 7 comments
Closed
1 of 3 tasks

Bump transitive dependencies to latest along with ion-tools #315

shamilovtim opened this issue Apr 18, 2023 · 7 comments
Labels
build Build related issues good first issue Good for newcomers

Comments

@shamilovtim
Copy link
Contributor

shamilovtim commented Apr 18, 2023

Context

In a package that uses dwn sdk and ion tools, the transitive dependencies start to look like this:
image

Multiple versions of unix-fs, multiformats, interface-blockstore, and so on. Many transitive dependencies are duplicated 3 or 4 times with different major versions pulled in.

This task can be broken down further to specific dependencies, but that's a detail for the OSE team.

Fixes:

  • bump all dependencies in dwn sdk to latest
  • bump all dependencies in ion tools to latest
  • make sure that ion tools and dwn sdk rely on the same versions of dependencies
@thehenrytsai thehenrytsai added good first issue Good for newcomers build Build related issues labels Apr 26, 2023
@thehenrytsai
Copy link
Contributor

This is essentially a duplicate of #245, but with additional requirements with ion-tools.

@thehenrytsai
Copy link
Contributor

@shamilovtim, bumped dwn-sdk version to latest in #245, please feel free to file an issue in ion-tools to update it's IPFS related dependencies if you are still having problem .

@shamilovtim
Copy link
Contributor Author

Related: decentralized-identity/ion-tools#53

@shamilovtim
Copy link
Contributor Author

shamilovtim commented May 30, 2023

I forgot to call this out: it isn’t just the ipfs ones. Same for dag/cbor , ipld, anything achingbrain, and anything paulmiller. Pretty much all of our transitive dependencies should be permissive about minor versions, and all of them should probably match across our open source projects so we aren’t burdening projects with 2x, 3x, 4x of the same heavy crypto based dependencies resolving.

@thehenrytsai
Copy link
Contributor

Closing this issue with a targeted issue for action #385.

@thehenrytsai
Copy link
Contributor

Reopening. The issue asks to update all dependencies, not just IPFS related ones.

@thehenrytsai thehenrytsai reopened this May 30, 2023
@thehenrytsai thehenrytsai added this to DWN May 31, 2023
@thehenrytsai thehenrytsai moved this to High Priority Backlog in DWN May 31, 2023
thehenrytsai added a commit that referenced this issue Jun 14, 2023
…changes (#396)

* #315 - updated all dependencies to latest version and fixed breaking changes
* Updated CJS build config to use ES6
* Incremented node version in github workflow
@thehenrytsai
Copy link
Contributor

#396 should address this issue on the DWN SDK side. Feel free to reference this commit in issue(s) in ION repo(s).

@github-project-automation github-project-automation bot moved this from High Priority Backlog to Done in DWN Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build related issues good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants