Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regex in JSON schema to check date properties in ISO 8601 UTC format #147

Closed
thehenrytsai opened this issue Nov 8, 2022 · 5 comments
Closed

Add regex in JSON schema to check date properties in ISO 8601 UTC format #147

thehenrytsai opened this issue Nov 8, 2022 · 5 comments
Assignees
@thehenrytsai
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thehenrytsai
Copy link
Contributor

See date format requirements in #113.

The regex should be added for dateCreated and datePublished properties.
@thehenrytsai thehenrytsai added feature New feature or request good first issue Good for newcomers labels Nov 8, 2022
@rajakash-dev
Copy link
Contributor

Can you please elaborate on how to use the regex , i have built and tested a regex exp but not sure how to use it in this use case.

@thehenrytsai
Copy link
Contributor Author

You can see regex examples in https://github.com/TBD54566975/dwn-sdk-js/blob/ecd72c95e4ab31f68dbd74d36bc3502967d163da/json-schemas/definitions.json used for validations.

@rajakash-dev
Copy link
Contributor

#150

@thehenrytsai thehenrytsai added the help wanted Extra attention is needed label Feb 7, 2023
@thehenrytsai thehenrytsai moved this to High Priority Backlog in DWN Feb 9, 2023
@thehenrytsai thehenrytsai added this to DWN Feb 9, 2023
@duncanmak duncanmak mentioned this issue Apr 25, 2023
Merged
@thehenrytsai thehenrytsai moved this from High Priority Backlog to In Progress in DWN Apr 27, 2023
@thehenrytsai thehenrytsai self-assigned this Apr 27, 2023
thehenrytsai pushed a commit that referenced this issue Apr 27, 2023
@duncanmak
#147 - Added regex in JSON schema to check date-time properties accep…
2519f8c 
…ted by DWN
@duncanmak
Copy link
Contributor

We can close this now!

@thehenrytsai
Copy link
Contributor Author

Yes we can!

@github-project-automation github-project-automation bot moved this from In Progress to Done in DWN Apr 27, 2023
This was referenced Oct 27, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thehenrytsai thehenrytsai

Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duncanmak @thehenrytsai @rajakash-dev