Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Interopathon Support (did:peer:4 & Empty Messages) #77

Merged

Conversation

TheTechmage
Copy link
Collaborator

In preparation for the DIDComm V2 Interopathon, these changes are bringing us closer to in-line with the requirements by adding support for did:peer:4 (we now generate and can resolve those DIDs) and empty messages

Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
This was built from @dbluhm's did:peer:4 ts library
https://github.com/dbluhm/did-peer-4-ts/

Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
src/lib/peer4/index.js Outdated Show resolved Hide resolved
Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
dbluhm
dbluhm previously approved these changes Oct 28, 2024
@dbluhm
Copy link
Member

dbluhm commented Oct 28, 2024

Several console logs that you might consider cleaning up or removing or logging to the "official" log that is displayed on the page

Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
@TheTechmage
Copy link
Collaborator Author

Unfortunately, updating those log lines to clarify and adding some to the logger marked your review as stale.
To clarify: Some logs are output to console.log because the logger.log expects strings only. Even if JSON and objects get stringified, having the text in the console log as "not an object" makes the object significantly more difficult to quickly parse what was contained within the message. A couple of the things that are being logged are also logged where the logger doesn't exist, such as: within the web worker.

One of these days, I think it would be worth-while to expand the logger to accept any[] instead of string[], and have the log renderer display "pretty" JSON output that is collapsible. But that is out-of-scope for this PR.

@TheTechmage TheTechmage merged commit afc6f27 into decentralized-identity:main Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants