Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept 32 or 64 bytes as keys for EdDSASigner #299

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

mirceanis
Copy link
Member

Only the first 32 bytes are used as the actual key

fixes #289

Only the first 32 bytes are used as the actual key
fixes #289
src/signers/EdDSASigner.ts Show resolved Hide resolved
@mirceanis mirceanis merged commit 546f31c into master Sep 27, 2023
2 checks passed
@mirceanis mirceanis deleted the 289-fix-key-length-for-eddsa-signer branch September 27, 2023 18:53
uport-automation-bot pushed a commit that referenced this pull request Sep 27, 2023
## [7.4.1](7.4.0...7.4.1) (2023-09-27)

### Bug Fixes

* accept 32 or 64 bytes as keys for EdDSASigner ([#299](#299)) ([546f31c](546f31c)), closes [#289](#289)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 7.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] EdDSA signer accepts a 64 bytes Uint8Array while EdDSA private key is 32 Bytes
3 participants