feat: interpret publicKeyMultibase as multicodec #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickreynolds
approved these changes
Sep 27, 2023
| * | ||
| * @public | ||
| */ | ||
| export function bytesToMultibase( |
There was a problem hiding this comment.
would it make sense to eventually pull this function into its own util package? we have a similar function in @veramo/utils as you know, and it would be best to not have to maintain 2 identical functions
There was a problem hiding this comment.
I'll use the function from here in veramo and remove the duplicate
mirceanis
force-pushed
the
297-multicodec-support
branch
from
d116640
to
9f80493
Compare
mirceanis
changed the title
|
🎉 This PR is included in version 7.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #297
Some users of
publicKeyMultibaseactually encode a multicodec prefixed byte array.This leads to keys that are not decoded properly and thus are not usable for verification.
This fix includes some heuristics to try to decode multibase directly if it fits known public key lengths and then attempt multicodec decoding.
This PR also exports the methods used for key conversions for use in other libraries.