Remove Recoverable Parameter from ES256Signer #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p into files by curve
…les as suggested by linter
…ithms, add a not for secp256r1 support of in src/VerifierAlgorithm.common.ts
…ted for u8a, temporarily commiting for now
to match upstream
… with secp256k1 not secp256r1
mirceanis
approved these changes
Sep 2, 2022
uport-automation-bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
## [6.6.1](6.6.0...6.6.1) (2022-09-02) ### Bug Fixes * remove `recoverable` parameter from ES256Signer ([#247](#247)) ([a68ac47](a68ac47))
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of #246 to remove the recovery parameter from ES256Signer for secp256r1 keys. This library attempts key recovery from Ethereum addresses. I believe this is invalid for secp256r1 public keys because Ethereum only uses secp256k1 keys.