Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ES256K-R verification with checksumAddress in eip155 blockchainAccountId #232

Merged
merged 1 commit into from
Jun 6, 2022
Merged

fix: ES256K-R verification with checksumAddress in eip155 blockchainAccountId #232

merged 1 commit into from
Jun 6, 2022

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Jun 6, 2022 •
edited
Loading

The fix is a case insensitive comparison of recovered addresses.

I also added a test to check for regressions of this issue.

fixes #231

@mirceanis mirceanis merged commit dcbd0b9 into master Jun 6, 2022
@mirceanis mirceanis deleted the 231-verify-with-checksumAddress branch June 6, 2022 11:03
uport-automation-bot pushed a commit that referenced this pull request Jun 6, 2022
@semantic-release-bot
chore(release): 6.1.2 [skip ci]
9c6e084 
## [6.1.2](6.1.1...6.1.2) (2022-06-06)

### Bug Fixes

* ES256K-R verification with checksumAddress in eip155 blockchainAccountId ([#232](#232)) ([dcbd0b9](dcbd0b9)), closes [#231](#231)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonas-notcat simonas-notcat simonas-notcat approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] verification of ES256K-R fails when verificationMethod uses checksumAddress in blockchainAccountId
3 participants
@mirceanis @uport-automation-bot @simonas-notcat