Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't run JSON.stringify on canonicalized data #172

Merged
merged 1 commit into from
May 19, 2021
Merged

fix: don't run JSON.stringify on canonicalized data #172

merged 1 commit into from
May 19, 2021

Conversation

yhuard
Copy link
Contributor

@yhuard yhuard commented May 19, 2021

Fixes #171

mirceanis
mirceanis approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thank you for your contribution

@mirceanis mirceanis merged commit 5480bfc into decentralized-identity:master May 19, 2021
uport-automation-bot pushed a commit that referenced this pull request May 19, 2021
@semantic-release-bot
chore(release): 5.4.1 [skip ci]
85dd02a 
## [5.4.1](5.4.0...5.4.1) (2021-05-19)

### Bug Fixes

* don't run JSON.stringify on canonicalized data ([#172](#172)) ([5480bfc](5480bfc)), closes [#171](#171)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 5.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{ canonicalize: true } stringifies the payload twice
3 participants
@yhuard @uport-automation-bot @mirceanis