Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify expected Resolver type in verify methods #159

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix: simplify expected Resolver type in verify methods #159

merged 1 commit into from
Mar 25, 2021

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Mar 24, 2021 •
edited
Loading

simonas-notcat
simonas-notcat approved these changes Mar 25, 2021
View reviewed changes
Copy link

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirceanis mirceanis merged commit 969de89 into master Mar 25, 2021
@mirceanis mirceanis deleted the resolver-type-signature branch March 25, 2021 16:23
uport-automation-bot pushed a commit that referenced this pull request Mar 25, 2021
@semantic-release-bot
chore(release): 5.1.1 [skip ci]
7de1ad9 
## [5.1.1](5.1.0...5.1.1) (2021-03-25)

### Bug Fixes

* simplify expected Resolver type in verify methods ([#159](#159)) ([969de89](969de89)), closes [#158](#158)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonas-notcat simonas-notcat simonas-notcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the use of Resolver type from did-resolver is too restrictive
3 participants
@mirceanis @uport-automation-bot @simonas-notcat